basho / rebar
Erlang Build Tools -- Please file bug and feature requests at http://issues.basho.com.
| commit 168: | 27b116bd3397 |
| parent 167: | 5b3b8e71be47 |
| branch: | default |
Update comment for filelib:ensure_dir/1 wrapper.
The wrapper can now be removed as I've fixed the problem in R13B04.
Tuncer Ayaz /
tuncer
5 months ago
5 months ago
Changed (Δ352 bytes):
raw changeset »
src/rebar_utils.erl (1 lines added, 8 lines removed)
Up to file-list src/rebar_utils.erl:
| … | … | @@ -96,14 +96,7 @@ now_str() -> |
96 |
96 |
lists:flatten(io_lib:format("~4b/~2..0b/~2..0b ~2..0b:~2..0b:~2..0b", |
97 |
97 |
[Year, Month, Day, Hour, Minute, Second])). |
98 |
98 |
|
99 |
%% TODO: Review why filelib:ensure_dir/1 sometimes returns {error, eexist}. |
|
100 |
%% There appears to be a race condition when calling ensure_dir from |
|
101 |
%% multiple processes simultaneously. |
|
102 |
%% This does not happen with -j1 but with anything higher than that. |
|
103 |
%% So -j2 or default jobs setting will reveal the issue. |
|
104 |
%% To reproduce make sure that the priv/mibs directory does not exist |
|
105 |
%% $ rm -r priv |
|
106 |
%% $ ./rebar -v compile |
|
99 |
%% TODO: filelib:ensure_dir/1 corrected in R13B04. Can be removed. |
|
107 |
100 |
ensure_dir(Path) -> |
108 |
101 |
case filelib:ensure_dir(Path) of |
109 |
102 |
ok -> |